Added ignore capability. #564
Conversation
|
I added tests for the enhancements to CSSLint and Reporter and actually changed/fixed some stuff uncovered by the tests. Please review critically and consider for merging. |
|
Anything I can do to make this get merged? |
|
It would really be awesome to get this new feature! |
|
+1! Please merge! |
|
👍 please merge this, having resets/normalizer is very common and should not lead to css linting problems. |
|
Yeah! +1 |
|
Can you merge this feature and release! |
|
👍 |
| ignoreStart = lineno; | ||
| } | ||
|
|
||
| if(line.match(/\/\*[ \t]*csslint[ \t]+ignore:stop[ \t]*\*\//i)) { |
There was a problem hiding this comment.
Just a nit, but I usually think of these as start/end, not start/stop. (So, more declarative, less imperative… ;)
|
How hard would it be to not run the rule in the ignore blocks? Would the order-alphabetical fail if you have something like: or: or: ? |
|
Please rebase and squash. Feature looks good to me. @bwinton , let's try to get this out there first. Your suggestion is maybe better suited for a new feature request, that may or may not be combined with this PR. |
|
Actually changed to ignore:end. One year later, this makes more sense to me also... |
|
Any chance this could get merged soon? It would be very helpful. |
|
👍 Changeset looks good to me. Tested on a locally merged version. Can you add documentation? https://github.com/CSSLint/csslint/wiki/ |
|
Added a small page with simple example: https://github.com/CSSLint/csslint/wiki/Ignoring-parts-of-CSS-during-linting |
|
@cwygoda Can you please rebase? |
|
@cwygoda Can you please rebase? |
Comments /* csslint ignore:start */ and /* csslint ignore:end */ will exclude the lines in between. Linting is still done, but any errors are not reported. This aims to fix #558.
|
Done. |
|
I added some words on it on the main wiki page. Thanks for your contribution. |
Comments /* csslint ignore:start / and / csslint ignore:stop */
will exclude the lines in between. Linting is still done, but any
errors are not reported.
This aims to fix #558.
This is still missing tests and docs. As I am on the road for the next couple of days I still wanted to provide what's been done so far. Comments welcome.