Allow dumping TSEC keys to sd card #44
Conversation
There was a problem hiding this comment.
Thank you for the PR.
Please check the comments on the code. They rectify some undefined behavior, have a more complete logic (for all possible cases) and lessen the compiled binary's size.
(I've made this review by eye and haven't compiled it to test it, so if you see anything strange tell me.)
EDIT:
And if it's possible, please squash the new changes into one commit.
ipl/main.c
Outdated
| @@ -665,31 +665,52 @@ void print_tsec_key() | |||
| { | |||
| EPRINTFARGS("Could not identify package1 version\nto read TSEC firmware (= '%s').", | |||
| (char *)pkg1 + 0x10); | |||
|
|
|||
| gfx_puts(&gfx_con, "\nPress any key...\n"); | |||
| btn_wait(); | |||
There was a problem hiding this comment.
Remove these 2.
Press any key is not needed anymore.
btn_wait is going to be used elsewhere.
ipl/main.c
Outdated
| } | ||
| else | ||
| EPRINTFARGS("ERROR %X", res); | ||
| gfx_putc(&gfx_con, '\n'); | ||
| } | ||
|
|
||
| free(pkg1); | ||
| sdmmc_storage_end(&storage); |
There was a problem hiding this comment.
Remove these 2.
They create undefined behavior when these 2 and the 2 at out label run.
| gfx_puts(&gfx_con, "\nDone!\n"); | ||
| sd_unmount(); | ||
| } | ||
| } |
ipl/main.c
Outdated
| gfx_puts(&gfx_con, "\nDone!\n"); | ||
| sd_unmount(); | ||
| } | ||
| } | ||
|
|
||
| out:; |
There was a problem hiding this comment.
Create a label out_wait:; above label out
and add btn_wait() below it.
ipl/main.c
Outdated
| @@ -665,31 +665,52 @@ void print_tsec_key() | |||
| { | |||
| EPRINTFARGS("Could not identify package1 version\nto read TSEC firmware (= '%s').", | |||
| (char *)pkg1 + 0x10); | |||
|
|
|||
| gfx_puts(&gfx_con, "\nPress any key...\n"); | |||
| btn_wait(); | |||
| goto out; | |||
|
Thank you for the comments, the requested changes have been made. Plus an additional change of moving |
|
Thank you! (Btw, |
|
Nice :D |
* Allow dumping tsec keys to sd card
It would be useful if we could dump the TSEC keys just like the fuses and kfuses