Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints nonfunctional unless logged in #2157

Closed
arxenix opened this issue Jul 31, 2022 · 2 comments · Fixed by #2333
Closed

Hints nonfunctional unless logged in #2157

arxenix opened this issue Jul 31, 2022 · 2 comments · Fixed by #2333
Milestone

Comments

@arxenix
Copy link

arxenix commented Jul 31, 2022

Environment:

  • CTFd Version/Commit: 3.5.0
  • Operating System: any
  • Web Browser and Version: any

What happened?
Clicking on a hint while being signed out does absolutely nothing. This makes it seem like the website is nonfunctional.

What did you expect to happen?
Hints with no cost should be viewable without being signed in. If the hint has a cost, an error/alert telling the user to sign in should be displayed.

How to reproduce your issue
Have a CTFd instance with the challenges page public, attempt to click on a challenge hint.

@ColdHeat
Copy link
Member

I thought this would be a straightforward UI change but this is actually an issue inside of the API since it needs to return hint data when users aren't authenticated. This is a bigger change than it looks so it could take some time.

@arxenix
Copy link
Author

arxenix commented Jul 31, 2022

yeah, for now I think a good alternative would be to simply tell the user they must be logged in to view a hint, rather than the button appearing unresponsive.

ColdHeat added a commit that referenced this issue Jun 16, 2023
* Free hints (those without a cost or prerequsitites) can now be viewed publicly if challenges are visible publicly
* Closes #2157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants