-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache problem fix #2268
base: master
Are you sure you want to change the base?
Cache problem fix #2268
Conversation
I actually have a need for the function you created so thanks for filing this! I do wonder if there's a way we could make use of the original query_string parameter but I admit that I haven't dug too much into the PR yet. |
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
+ Coverage 87.61% 87.63% +0.01%
==========================================
Files 145 145
Lines 8851 8865 +14
==========================================
+ Hits 7755 7769 +14
Misses 1096 1096
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Let me describe some things: Regarding the This is the reason why I decided to script a new But my changes also introduce a new problem. Now the cache key includes a user defined input thus it should be used with caution and it is not always predictable. Examples:
In this particular case, the user input is always |
The caching of the API that returns the scoreboard does not take into that the given parameters may have changed.