Remove @during_ctf_time_only from /challenges #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method already gracefully handles being requested before the CTF starts.
By removing @during_ctf_time_only, we get a nicer error message ("<ctf
name> has not started yet" vs a 403).
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
==========================================
- Coverage 74.4% 74.39% -0.01%
==========================================
Files 19 19
Lines 2778 2777 -1
==========================================
- Hits 2067 2066 -1
Misses 711 711
Continue to review full report at Codecov.
|
|
You'd need to target this to 2.0.0 and it's unlikely that that change will be accepted b/c of how heavily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method already gracefully handles being requested before the CTF starts.
By removing @during_ctf_time_only, we get a nicer error message (" has not started yet" vs a 403).