Remove unnecessary code that breaks jQuery 3 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event.props was removed in jquery 3 (jquery/api.jquery.com#405). It looks like this wasn't doing anything useful, and broke the schedule editor.
It is not present in modern Firefox. Use the event argument we got.
hodgestar
approved these changes
Nov 9, 2016
| if (e.stopPropagation) { | ||
| e.stopPropagation(); // stops the browser from redirecting. | ||
| } | ||
| e.preventDefault(); // stops the browser from redirecting | ||
|
|
||
| var slot = e.target.getAttribute('data-slot'); | ||
| var venue = e.target.getAttribute('data-venue'); | ||
|
|
||
| //noinspection JSUnresolvedVariable |
There was a problem hiding this comment.
Can we remove this comment now?
Any idea how the event. references worked before? Some sort of crazy magic?
There was a problem hiding this comment.
Apparently it's a legacy thing: http://stackoverflow.com/a/20522980
There was a problem hiding this comment.
Cool. Let's remove the noinspection then.
Not sure what they were used for, the Internet says IntilliJ. Add a JSHint/JSLint declaration of used globals.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event.props was removed in jquery 3 (jquery/api.jquery.com#405).
It looks like this wasn't doing anything useful, and broke the schedule
editor.