Recent dev vs. tools/build/test-includes

[nwf]

FWIW, a clean build of dev fails to make much progress on my machine because all the sys/_*.h files now get included and all, quite deliberately, cause the compiler to bomb out with "don't do that" errors.

I believe this an upstream FreeBSD issue and is, ultimately, because

cheribsd/tools/build/test-includes/Makefile

Line 19 in d3bb19c

HDRS!= (cd ${SRCTOP}/sys; ls sys/[^_]*.h | sort ; ls net*/[^_]*.h | sort)

is not actually spec conformant. In particular, X/Open CAE Specification Commands and Utilities Issue 4, Version 2 sayeth:

The description of basic regular expression bracket expressions in the XBD specification, Section
7.3.5, RE Bracket Expression also applies to the pattern bracket expression, except that the
exclamation-mark character (!) replaces the circumflex character (ˆ) in its role in a non-matching
list in the regular expression notation. A bracket expression starting with an unquoted
circumflex character produces unspecified results.

There must be something about my setup that elicits these "unspecified results", though I hesitate to speculate which of its many, many "charming features", exactly, that might be.

[brooksdavis]

From the FreeBSD manpage:

The character class may be complemented by making an exclamation
point ('!') the first character of the character class. A caret ('^')
has the same effect but is non-standard.

Could you test with ! in place of ^? If that works I can prod Warner.

[nwf]

That (! and not ^) seems to work fine.

[brooksdavis]

Submitted for review https://reviews.freebsd.org/D34597

[brooksdavis]

Merged to dev