Skip to content

Commit

Permalink
test-includes: improve portability
Browse files Browse the repository at this point in the history
FreeBSD's shell permits [^bar] to match characters not in [bar] like
common regular expressions. This is non-portable and '!' should be
used in place of '^' for portability.

Reported by:	Nathaniel Wesley Filardo
Issue:		CTSRD-CHERI/cheribsd#1321
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D34597
  • Loading branch information
brooksdavis committed Mar 22, 2022
1 parent 8422d54 commit 44b36b8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/build/test-includes/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
LIB= test-includes
INTERNALLIB= This is a compile-only test
MAN=
HDRS!= (cd ${SRCTOP}/sys; ls sys/[^_]*.h | sort ; ls net*/[^_]*.h | sort)
HDRS!= (cd ${SRCTOP}/sys; ls sys/[!_]*.h | sort ; ls net*/[!_]*.h | sort)
NO_PIC= yes

# Some files have to be clean for extra defines too...
Expand Down

0 comments on commit 44b36b8

Please sign in to comment.