Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-20317] fixed global lowest_active_mvccid initialization #112

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

alexstanro
Copy link
Contributor

@alexstanro alexstanro commented Jun 21, 2016

initialized global lowest_active_mvccid with next MVCCID

@eseokoh eseokoh added the bug label Jun 21, 2016
@eseokoh eseokoh changed the title fixed global lowest_active_mvccid initialization [CBRD-20317] fixed global lowest_active_mvccid initialization Jun 21, 2016
@eseokoh
Copy link
Contributor

eseokoh commented Jun 21, 2016

@alexstanro

Please merge the fix and resolve all the related issues.
Thank you. 😃

@alexstanro alexstanro merged commit 7fadeca into CUBRID:develop Jun 21, 2016
@eseokoh eseokoh modified the milestone: banana pie May 12, 2017
ribram added a commit to ribram/cubrid that referenced this pull request May 21, 2021
…RID#123)

* [SC-322] Add const qualifier to function arguments that don't change (CUBRID#112)

https://arniadb.atlassian.net/browse/SC-322

Add const qualifier to function arguments that don't change in functions used by serial.

* [SC-60] Add new serial::attrinfo and serial::heap_record classes (CUBRID#114)

https://arniadb.atlassian.net/browse/SC-60

Add two new classes to encapsulate repeated code used by serial objects.

**serial::heap_record** is a storage class specialized in reading and updating the heap record of a serial object.

  - owns heap_scancache
  - read () & update () heap record

**serial::attrinfo** is a query class specialized in reading and updating the heap_cache_attrinfo of a serial object

  - owns heap_cache_attrinfo
  - all code reading from and writing to attrinfo was moved here
  - generate a record descriptor based on attrinfo values
  - all globals/functions managing the conversion table from attribute indexes to attribute ids was moved to unit file (including partial code from serial_initialize_cache_pool)
  - attribute indexes enum moved to header

**serial.c** refactoring using the two classes.

  - use serial_heap_record & serial_attrinfo to avoid repeated code.
  - new function serial_read_record_and_attrinfo
  - use global oid_Serial_class_oid instead of local serial class OID variables/arguments
  - move reading serial name (key) to serial_update_serial_object (the only place it is used)
  - remove branch of code if CACHED_NUM attribute does not exist (it does)

* Reorder header include in serial.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants