003 error model #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobsj
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Thank you for this nice notebook! It's great to EEM and variants can be implemented and demonstrated with CUQIpy! I'm not so familiar with these methods so I didn't check the formulas and results in detail, but I like the flow and organization of the notebook and made just some minor suggestions.
add reviewer by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
jakobsj
requested changes
Nov 30, 2023
fix typos by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
fix equation by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
Fix typo by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update wording by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update notation of prior by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update notation of prior Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update notation of prior by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update notation of prior by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
update equation by Jakob Co-authored-by: Jakob Sauer Jørgensen <jakobsj@users.noreply.github.com>
|
@jakobsj Thanks and I'll merger it to main then |
|
closes #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notebook from Puyuan Mi
closes #11