Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REECA1 fix #240

Merged
merged 7 commits into from
Dec 21, 2021
Merged

REECA1 fix #240

merged 7 commits into from
Dec 21, 2021

Conversation

jinningwang
Copy link
Member

debug_REECA1

No. 1
When SWV_s0 = 1, SWPF_s0 =1,
PIV_input = Vref1 + Qref – Vt, which should be 0, so I fixed the equations of Qref.

No. 2
Also, when SWPF_s0 =1, it means PIQ is out of use, I fixed its input equation to make sure it is 0.
The input equation of PIQ is changed to make sure the input is 0.

No. 3
When SWQ_s0 = 1, SWPF_s0 =1,
S4_input = PFsel / vp, which should be Iqcmd0. However, the Qref is set by PIV, so I add an additional constant value in s4_input.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #240 (9d4bc1d) into develop (641e9ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #240   +/-   ##
========================================
  Coverage    78.50%   78.50%           
========================================
  Files          151      151           
  Lines        12835    12837    +2     
========================================
+ Hits         10076    10078    +2     
  Misses        2759     2759           
Impacted Files Coverage Δ
andes/models/governor/hygov.py 100.00% <ø> (ø)
andes/models/renewable/reeca1.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641e9ba...9d4bc1d. Read the comment docs.

@cuihantao
Copy link
Collaborator

Hi @jinningwang, just want to check if you received notifications of the comments above. Thanks.

@jinningwang
Copy link
Member Author

Hi @jinningwang, just want to check if you received notifications of the comments above. Thanks.

Hi Hantao,

I checked the code and s4in should be removed since it is not used anymore.

Regards,
Jinning

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cuihantao cuihantao merged commit 58c8018 into CURENT:develop Dec 21, 2021
@jinningwang jinningwang deleted the mdlfix branch March 26, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants