-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REECA1 fix #240
REECA1 fix #240
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #240 +/- ##
========================================
Coverage 78.50% 78.50%
========================================
Files 151 151
Lines 12835 12837 +2
========================================
+ Hits 10076 10078 +2
Misses 2759 2759
Continue to review full report at Codecov.
|
Hi @jinningwang, just want to check if you received notifications of the comments above. Thanks. |
Hi Hantao, I checked the code and s4in should be removed since it is not used anymore. Regards, |
Kudos, SonarCloud Quality Gate passed! |
No. 1
When SWV_s0 = 1, SWPF_s0 =1,
PIV_input = Vref1 + Qref – Vt, which should be 0, so I fixed the equations of Qref.
No. 2
Also, when SWPF_s0 =1, it means PIQ is out of use, I fixed its input equation to make sure it is 0.
The input equation of PIQ is changed to make sure the input is 0.
No. 3
When SWQ_s0 = 1, SWPF_s0 =1,
S4_input = PFsel / vp, which should be Iqcmd0. However, the Qref is set by PIV, so I add an additional constant value in s4_input.