Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Implement errors for GTFS-rt v2.0 #262

Closed
barbeau opened this issue Aug 10, 2017 · 0 comments
Closed

Implement errors for GTFS-rt v2.0 #262

barbeau opened this issue Aug 10, 2017 · 0 comments

Comments

@barbeau
Copy link
Member

barbeau commented Aug 10, 2017

Summary:

We successfully proposed a v2.0 of the GTFS-rt spec (google/transit#64), which now includes semantic cardinality and requirements for fields - in other words, under certain logical transit conditions, some fields are now required that were previously labeled as "optional" under v1.0.

We can implement new errors that are triggered if the gtfs_realtime_version is 2 and the fields aren't provided, including:

  • FeedHeader.incrementality
  • FeedHeader.timestamp

...and more.

We also need to revise E038 with the new supported version 2.0.

Steps to reproduce:

Run the validator on a v2.0 GTFS-rt feed

Expected behavior:

The validator should throw errors if v2.0 required fields aren't provided.

Observed behavior:

The current validator is designed only for GTFS-rt v1.0 - things like missing FeedHeader.timestamp are only logged as warnings (W001).

@barbeau barbeau added this to the v1.0 milestone Aug 10, 2017
barbeau added a commit that referenced this issue Aug 29, 2017
* Add v2.0 as a valid GTFS-rt version and update test

TODO:
* New rule for FeedHeader.incrementality error
* New rule for FeedHeader.timestamp error
barbeau added a commit that referenced this issue Sep 1, 2017
* New rule E048 - header timestamp not populated (GTFS-rt v2.0 and higher)
* New rule E049 - header incrementality not populated (GTFS-rt v2.0 and higher)
@barbeau barbeau closed this as completed in 25cbfa0 Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant