Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ext-rewrite-quant) Refutation soundness bug in LIA #5740

Closed
muchang opened this issue Jan 5, 2021 · 1 comment · Fixed by #5760
Closed

(ext-rewrite-quant) Refutation soundness bug in LIA #5740

muchang opened this issue Jan 5, 2021 · 1 comment · Fixed by #5760
Assignees

Comments

@muchang
Copy link

muchang commented Jan 5, 2021

[766] % cvc4 -q small.smt2
sat
[767] % cvc4 -q --ext-rewrite-quant small.smt2
unsat
[768] % cat small.smt2
(define-fun f ((a Int) (b Int)) Int (ite (= b 0) 0 a))
(assert (exists ((c Int)) (distinct (f c (mod 0 0)) 0)))
(check-sat)
[769] % 

Commit: e0dfc0a

@muchang
Copy link
Author

muchang commented Jan 5, 2021

Another case:

[855] % cvc4 -q small.smt2
unknown
[856] % z3release small.smt2
sat
[857] % cvc4 -q --ext-rewrite-quant small.smt2
unsat
[858] % 
[858] % cat small.smt2
(declare-fun c (Int) Bool)
(define-fun d ((e Int)) Bool (forall ((a Int) (b Int)) (! true :pattern ((c a) (c b)))))
(assert (exists ((e Int)) (distinct (d e) (= (ite (= e 0) (mod 0 e) 0) 0))))
(check-sat)
[859] % 

Commit: e0dfc0a

@ajreynol ajreynol self-assigned this Jan 9, 2021
ajreynol added a commit that referenced this issue Jan 11, 2021
This rewrite is no longer needed since our philosophy on rewriting extended arithmetic symbols has changed (we employ aggressive rewriting for extended arithmetic symbols in the normal rewriter). Moreover there was a soundness bug in the extended rewriter for division and mod by 0.

Fixes #5737, fixes #5740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants