fix for some provider return birthdate:null in userInfo #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schlenk seems the code check failed has nothing to do with this PR? |
|
yes, that is some mypy changes fallout. I'll take a look later today. |
Signed-off-by: Li Chaoran <pkwarcraft@gmail.com>
The spec allows null values or empty strings in UserInfo responses. Make the client accept those values but normalize and drop empty values when parsing the message.
|
I change the fix a bit. Your fix was fine, but would cause an exception when used in a client to fetch userinfo, as the |
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 63.80% 63.80% -0.01%
==========================================
Files 64 64
Lines 11877 11882 +5
Branches 2158 2159 +1
==========================================
+ Hits 7578 7581 +3
- Misses 3695 3696 +1
- Partials 604 605 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlenk
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Li Chaoran pkwarcraft@gmail.com
CHANGELOG.md.the code is straightforward, no need any comments :)
fix #830