Repair some oauth_examples and get rid of the outdated jquery file #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 63.83% 63.83%
=======================================
Files 64 64
Lines 11879 11879
Branches 2155 2155
=======================================
Hits 7583 7583
Misses 3693 3693
Partials 603 603 ☔ View full report in Codecov by Sentry. |
tpazderka
reviewed
May 2, 2023
Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
|
Quality should pass on the oauth_example dir at least, didn't look at the oidc_example parts. |
tpazderka
approved these changes
May 2, 2023
infohash
added a commit
to infohash/pyoidc
that referenced
this pull request
Jul 2, 2023
commit 5245dca Author: tpazderka <tomas.pazderka@nic.cz> Date: Tue May 16 19:48:56 2023 +0200 Fix building of the documentation (CZ-NIC#860) commit ba65e00 Author: Tomáš Pazderka <tomas.pazderka@nic.cz> Date: Mon May 15 09:01:02 2023 +0200 Prepare 1.6.0 release commit cfd0b6e Author: Michael Schlenker <MichaelSchlenker@gmx.net> Date: Tue May 2 14:02:37 2023 +0200 Repair some oauth_examples and get rid of the outdated jquery file (CZ-NIC#857) * More cleanup * Add oauth_example to quality checks Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com> * Update CHANGELOG.md --------- Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com> Co-authored-by: Michael Schlenker <michael.schlenker@contact-software.com> commit 444bd68 Merge: 3b1a9c3 433017c Author: tpazderka <tomas.pazderka@nic.cz> Date: Wed Apr 5 13:59:40 2023 +0200 Merge pull request CZ-NIC#854 from gbip/853_session_state Use session_state to backup consumer state if available commit 433017c Author: Paul Florence <paul.florence@makina-corpus.com> Date: Mon Apr 3 17:37:30 2023 +0200 Use 'session_state' from an Authentication Response to backup consumer state (if available) commit 3b1a9c3 Merge: a8454e3 1d46f09 Author: tpazderka <tomas.pazderka@nic.cz> Date: Mon Mar 27 09:24:34 2023 +0200 Merge pull request CZ-NIC#852 from CZ-NIC/851-add-consumer-complete-authn-method Add authn_method to Consumer.complete() commit 1d46f09 Author: Jan Musílek <jan.musilek@nic.cz> Date: Thu Mar 23 16:25:48 2023 +0100 Add authn_method to Consumer.complete() commit a8454e3 Merge: 559c9c8 a855642 Author: tpazderka <tomas.pazderka@nic.cz> Date: Fri Mar 17 13:16:25 2023 +0100 Merge pull request CZ-NIC#850 from hlin/master Correct OpenID Connect Core specification URL in doc commit a855642 Author: Hypo Lin <hlin@hypo.name> Date: Fri Mar 17 18:56:19 2023 +0800 Correct OpenID Connect Core specification URL in doc commit 559c9c8 Merge: 76debd6 9670f83 Author: tpazderka <tomas.pazderka@nic.cz> Date: Mon Mar 13 16:06:25 2023 +0100 Merge pull request CZ-NIC#847 from CZ-NIC/use-pydantic Improve settings by using pydantic commit 9670f83 Author: Tomáš Pazderka <tomas.pazderka@nic.cz> Date: Mon Feb 20 12:42:46 2023 +0100 Improve settings by using pydantic commit 76debd6 Merge: 6f7f893 94d1f99 Author: tpazderka <tomas.pazderka@nic.cz> Date: Mon Mar 13 14:54:53 2023 +0100 Merge pull request CZ-NIC#848 from CZ-NIC/bandit-timeouts Pass timeout to all requests commit 94d1f99 Author: Tomáš Pazderka <tomas.pazderka@nic.cz> Date: Fri Mar 10 10:19:00 2023 +0100 Pass timeout to all requests commit 6f7f893 Merge: f6c590c 12247bc Author: tpazderka <tomas.pazderka@nic.cz> Date: Mon Feb 20 09:38:17 2023 +0100 Merge pull request CZ-NIC#846 from CZ-NIC/repo-move Fix links after repo move commit 12247bc Author: Tomáš Pazderka <tomas.pazderka@nic.cz> Date: Fri Feb 17 11:50:41 2023 +0100 Fix links after repo move Close CZ-NIC#845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minimal cleanup of the oauth_example.
This is still a total mess and a really bad cherrypy application. But at least the servers now start and at least the RP seems to do something basically useful.
Remove the useless jquery 1.9.1 dependency that Dependabot complains about (its flagged as security issue, bogus, but better to get rid of it).
Remove references to missing files in the examples
Use modern cherrypy syntax for the wsgi server setup
Run Black & Isort on the oauth_example folder
Fix some minor breakage
Any changes relevant to users are recorded in the
CHANGELOG.md.The documentation has been updated, if necessary.
New code is annotated.
Changes are covered by tests.