Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Include "enable" in upstart for haas-proxy (first installation) #4

Closed
wants to merge 1 commit into from
Closed

Conversation

ooonea
Copy link
Contributor

@ooonea ooonea commented Dec 5, 2020

Added enable to haas-proxy service. Otherwise it will not start on reboot.

@BKPepe
Copy link
Contributor

BKPepe commented Dec 5, 2020

Hello @lucenera!

Thank you for your contribution. I think there isn't anything wrong to include enable there as well as start. This is common approach within OpenWrt.
Because this can cover cases when our patch with services_wanted [1] does not work as it should. It should be enabled automatically once Honeypot as Service is installed. 🤔But doing this manually does not harm.

Can you please update commit subject to be more related to commit description? After that, I can approve it.

[1] https://gitlab.nic.cz/turris/turris-build/-/blob/v5.1.4/patches/openwrt/hack/0001-base-files-do-not-automatically-activate-services-an.patch#L66

@ooonea ooonea changed the title Update setup.md Include "enable" in upstart for haas-proxy (first installation) Dec 6, 2020
Added enable to haas-proxy service. Otherwise it will not start on reboot.
@ooonea
Copy link
Contributor Author

ooonea commented Dec 6, 2020

I changed the commit subject. I hope this goes better 😉

@BKPepe
Copy link
Contributor

BKPepe commented Dec 10, 2020

This is going to be properly by this issue https://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues/5 , but including enable should not harm and it is common approach in OpenWrt, so @ljelinek-cznic can you merge this? :)

@BKPepe
Copy link
Contributor

BKPepe commented Jan 4, 2021

It is now part of our repository. For reference commit: 0eabb0a

Thank you for your contribution.

@BKPepe BKPepe closed this Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants