Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing Graphs, zoom functionality prevents drag and drop of image #3525

Closed
eschoeller opened this issue May 1, 2020 · 11 comments
Closed
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team gui UI related issue resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

I was previously on 1.2.9 and I was LOVING the ability to drag and drop graphs directly out of Cacti and into e-mail and other apps. It was wonderful. Now I'm on 1.2.11 and that functionality is gone, sadly. I'm on older versions of firefox and chrome.

@eschoeller eschoeller added bug Undesired behaviour unverified Some days we don't have a clue labels May 1, 2020
@eschoeller
Copy link
Author

This browser has the problem:

Chromium	80.0.3987.162 (Developer Build) built on Debian 10.3, running on Debian 10.3 (64-bit)
Revision	f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS	Linux
JavaScript	V8 8.0.426.29
Flash	(Disabled)
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.162 Safari/537.36
Command Line	/usr/lib/chromium/chromium --show-component-extension-options --enable-gpu-rasterization --no-default-browser-check --disable-pings --media-router=0 --enable-remote-extensions --load-extension --flag-switches-begin --flag-switches-end --disable-webrtc-apm-in-audio-service --file-url-path-alias=/gen=/usr/lib/chromium/gen
Executable Path	/usr/lib/chromium/chromium
Profile Path	/home/eric/.config/chromium/Default

@netniV
Copy link
Member

netniV commented May 1, 2020

I can confirm that I see you can't drag and drop images on the latest version of Cacti, but I have yet to test older ones so I left this unconfirmed at the moment.

Not sure we ever intended that functionality so it was a happy side effect if not.

@netniV netniV added the gui UI related issue label May 1, 2020
@eschoeller
Copy link
Author

It's been so incredibly useful I can't overstate that enough. having to save a graph somewhere, then open a file browser, find where the heck it was saved and what the heck it's called, and then drag the image over to another app seems simple, but doing that repetitively over time is a real drag (haha!). Having the ability to skip all that has made sharing data quickly so much easier. Especially when handling real-time incidents and communicating with other people in the middle of fault diagnosis.

@eschoeller
Copy link
Author

I'd be happy to upgrade from 1.2.9 to 1.2.10 to see if it still works. I just can't do that until Monday.

@netniV
Copy link
Member

netniV commented May 2, 2020

I'm on .12 and I have the issue so I doubt it's fixed.

@eschoeller
Copy link
Author

OK. There's a regression somewhere so I can try to replicate in .10 and see where it started. Just can't until Monday. Do you have an idea on what makes an image drag n' drop-able?

@eschoeller
Copy link
Author

And FYI ... this drag n' drop did NOT work earlier on ... somehow it started working ... perhaps in 1.2.9

@netniV
Copy link
Member

netniV commented May 4, 2020

Here's a weird tip... click the image you want to drag, click another image, click and drag the first image you wanted to drag... bingo .... O.o

@netniV
Copy link
Member

netniV commented May 4, 2020

Ok, so this appears to be something do with the graph zoom functionality. Because if you use my above tip, the mouse point does not change to a cross on the first image after you've clicked on one of the others.

@netniV
Copy link
Member

netniV commented May 4, 2020

Yeah, I believe the problem is that whilst zoom is active on an image, what you are trying to do is drag and drop the zoom-container object, rather than the underly image object.

@netniV netniV changed the title Drag and Drop no longer works When viewing Graphs, zoom functionality prevents drag and drop of image May 4, 2020
@netniV
Copy link
Member

netniV commented May 4, 2020

I believe that this is now resolved. However, it has the side effect, that you can no longer right click just anywhere for the graph menu, it must be on the graph itself, not the legends.

@netniV netniV added confirmed Bug is confirm by dev team resolved A fixed issue and removed unverified Some days we don't have a clue labels May 4, 2020
@netniV netniV added this to the 1.2.13 milestone May 4, 2020
@netniV netniV closed this as completed in 46a31c7 May 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team gui UI related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants