Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph template for NetSNMP lmsensors missing #5167

Closed
Xake opened this issue Jan 15, 2023 · 1 comment
Closed

Graph template for NetSNMP lmsensors missing #5167

Xake opened this issue Jan 15, 2023 · 1 comment
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.24

Comments

@Xake
Copy link
Contributor

Xake commented Jan 15, 2023

Graph templates where introduced in git between 1.2.22 and 1.2.23 as part of issue #4907 as commit 2278415
It is still mentioned in the CHANGELOG for 1.2.23

However just before 1.2.23 it was silently dropped (by mistake?) as part of commit 7701a6b

Please verify if they where supposed to be shipped, and in that case, reintroduce them, or maybe mention in the CHANGELOG why they were dropped.
@Xake Xake added bug Undesired behaviour unverified Some days we don't have a clue labels Jan 15, 2023
@TheWitness
Copy link
Member

TheWitness commented Jan 16, 2023 •
edited

Yea, I had a slip up on package management in the 1.2.23 release. More than just one issue. I'm in the process of remediating. Once you see this ticket resolved, you will know that I've caught things up.

@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jan 16, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 16, 2023
TheWitness added a commit that referenced this issue Jan 16, 2023
@TheWitness
Resolving #5167 and #5151 - Packages
1835da6 
Okay.  This may note be final commit.  Need to do some testing first.
TheWitness added a commit that referenced this issue Jan 16, 2023
@TheWitness
Changelog for #5151 and #5167
cc732bc
@TheWitness TheWitness added the resolved A fixed issue label Jan 16, 2023
TheWitness added a commit that referenced this issue Jan 16, 2023
@TheWitness
QA: Package QA for #5167 and #5151
ce7e7d3 
Packages look good now.  Back to spec
TheWitness added a commit that referenced this issue Jan 19, 2023
@TheWitness
Fixing #5151 and #5167 - Template Issues
19ea27d
TheWitness added a commit that referenced this issue Jan 22, 2023
@TheWitness
Updating CHANGELOG
5b1b8fc 
Confirmed #5150, #5151, #5159, #5161, #5167, #5168, #5174
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.24
Development

No branches or pull requests
2 participants
@Xake @TheWitness