Added tooltip to changepassword #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "ok" message when changing passwords.
Somethings that still needs to be looked at
1. can i read the friendly_name of the array with read_config_option? I want to read it from the array instead of typing it:
"Require Mix Case: " .read_config_option('secpass_reqmixcase') . "<br>" .
2. Because this function it still forces you to use a new password even to secpass_history default is set to 0. Change secpass_history default to 1 and remove it?
if ($user['password'] == md5(get_nfilter_request_var('password'))) {
$bad_password = true;
$errorMessage = "<span color='#FF0000'>Your new password can not be the same as the old password. Please try again.</span>";
}
3. I had to add font-awesome since it wasn't referenced anywhere in themes. Better way to do it?
Any input is welcome!
|
You can read it from the array itself by indexing into the global array. However, lets merge this as is. It's still broken as strong password support did not get comprehended. If you look at the change password function, it will hash the password per the php functions if your php version is higher than 5.5. So, the comparison function will not work with those higher php version. |
cigamit
added a commit
that referenced
this pull request
Mar 19, 2016
Still some work to do in order to support strong passwords though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "ok" message when changing passwords.
Somethings that still needs to be looked at:
can i read the friendly_name of the array with read_config_option? I want to read it from the array instead of typing it:
Because of this function it still forces you to use a new password even to secpass_history default is set to 0. Change secpass_history default to 1 and remove it?
if ($user['password'] == md5(get_nfilter_request_var('password'))) { $bad_password = true; $errorMessage = "<span color='#FF0000'>Your new password can not be the same as the old password. Please try again.</span>"; }print "\t<link href='" . $config['url_path'] . "include/" . "/fa/css/font-awesome.css' type='text/css' rel='stylesheet'>\n";Any input is welcome!