When using MySQL 8 or above, 'function' is considered a reserved word unless quoted #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would imagine there are other uses of the plugin_hooks table that also utilise the function keyword, have you checked for them? Also, the CHANGELOG should be updated. |
|
yes, I checked all php, I made few grep and it seems that problem is only on one line |
|
That's for doing the testing on MySQL 8.x |
netniV
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with new MySQL version,
functionis reserved word now:https://dev.mysql.com/doc/refman/8.0/en/keywords.html
2019/05/10 16:04:17 - CMDPHP SQL Backtrace: (/plugins.php[74]:api_plugin_install(), /lib/plugins.php[626]:plugin_intropage_install(), /plugins/intropage/setup.php[22]:api_plugin_register_hook(), /lib/plugins.php[736]:db_execute_prepared())
2019/05/10 16:04:17 - CMDPHP ERROR: A DB Exec Failed!, Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'function, file, status) VALUES ('intropage', 'poller_bottom', 'intropage_poller_' at line 1