Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tag based constraint definition #514

Merged
merged 8 commits into from
Nov 24, 2020
Merged

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #467 .

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #514 (55d1f3c) into master (ec9cd46) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   93.75%   94.13%   +0.37%     
==========================================
  Files          30       30              
  Lines        6007     6800     +793     
  Branches      637      765     +128     
==========================================
+ Hits         5632     6401     +769     
- Misses        237      254      +17     
- Partials      138      145       +7     
Impacted Files Coverage Δ
cadquery/assembly.py 90.00% <100.00%> (+1.56%) ⬆️
cadquery/cq.py 88.67% <100.00%> (+0.22%) ⬆️
tests/test_assembly.py 100.00% <100.00%> (ø)
tests/test_cadquery.py 99.03% <100.00%> (+<0.01%) ⬆️
tests/test_cad_objects.py 98.23% <0.00%> (-0.77%) ⬇️
tests/test_selectors.py 100.00% <0.00%> (ø)
cadquery/selectors.py 99.38% <0.00%> (+0.28%) ⬆️
cadquery/occ_impl/shapes.py 92.94% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9cd46...20eb996. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title Implement tag based constraint definition [WIP] Implement tag based constraint definition Nov 24, 2020
@adam-urbanczyk
Copy link
Member Author

I think this PR is ready for merging, could you take a look @jmwright ?

@adam-urbanczyk
Copy link
Member Author

@marcus7070 you are probably also interested

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk Looks good, thanks!

cadquery/cq.py Outdated Show resolved Hide resolved
@jmwright jmwright mentioned this pull request Nov 24, 2020
@adam-urbanczyk adam-urbanczyk merged commit b22436c into master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tags for defining assembly constraints
3 participants