[WIP] - Trying to move to env variable in Appveyor #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The #510 is not a real issue, the token is encrypted. It does sound like an additional safety net though. |
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 30 30
Lines 6115 6115
Branches 640 640
=======================================
Hits 5745 5745
Misses 235 235
Partials 135 135 Continue to review full report at Codecov.
|
|
I'm going to go ahead and merge this. |
|
Thanks, @jmwright . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adam-urbanczyk Don't merge yet, I need to see if the environment variable works as expected.
Doing this will resolve #510 and adds another layer of security.