-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly hierarchy - 2nd take #545
Conversation
CC: @bernhard-42 |
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 94.15% 94.30% +0.14%
==========================================
Files 29 29
Lines 6189 6334 +145
Branches 655 670 +15
==========================================
+ Hits 5827 5973 +146
Misses 224 224
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
Looks ok to me. Thanks. |
@bernhard-42 do you agree with merging this for now? Based on the discussion in #543 you have some design choices to be made that might take some time. |
@adam-urbanczyk fine for me. I do have a plan forward. Thanks for adding the hierarchies and the |
OK, I'll merge tomorrow. |
This PR solves nested assembly naming and enforces unique names on a single assembly level.