-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include path when both path and filename specified #9
Conversation
parfive/downloader.py
Outdated
if not filename: | ||
filepath = partial(default_name, path) | ||
elif callable(filename): | ||
filepath = filename | ||
else: | ||
path = pathlib.Path(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can path
be None
here? (I think it can?)
This has made me think a little more about the The only thing I wonder if it might be worth documenting is that this allows you to specify a full filepath to |
The only precedence I can think of is |
1 similar comment
The only precedence I can think of is |
Thanks @dstansby |
Currently if the filename and path are specified, path is ignored and the file is just downloaded to the current working directory. This should fix it. I've used pathlib because that's what I'm used to, not sure if it wants to be
os.path.join
instead.