fix: Hook directly into SpriteAtlasTexture for visiblity tracking (#532)

Covers a few additional cases such as animated paintings and effect icons. Fixes #248 and #403.
CaffeineMC · Feb 25, 2021 · caa6837 · caa6837
1 parent 38e5b45
commit caa6837
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...xture_tracking/MixinSpriteIdentifier.java → ...ure_tracking/MixinSpriteAtlasTexture.java b/...xture_tracking/MixinSpriteIdentifier.java → ...ure_tracking/MixinSpriteAtlasTexture.java
@@ -2,14 +2,14 @@
 
 import me.jellysquid.mods.sodium.client.render.texture.SpriteUtil;
 import net.minecraft.client.texture.Sprite;
-import net.minecraft.client.util.SpriteIdentifier;
+import net.minecraft.client.texture.SpriteAtlasTexture;
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
 
-@Mixin(SpriteIdentifier.class)
-public class MixinSpriteIdentifier {
+@Mixin(SpriteAtlasTexture.class)
+public class MixinSpriteAtlasTexture {
     @Inject(method = "getSprite", at = @At("RETURN"))
     private void preReturnSprite(CallbackInfoReturnable<Sprite> cir) {
         Sprite sprite = cir.getReturnValue();

diff --git a/src/main/resources/sodium.mixins.json b/src/main/resources/sodium.mixins.json
@@ -46,7 +46,7 @@
     "features.particle.fast_render.MixinBillboardParticle",
     "features.render_layer.MixinRenderLayers",
     "features.texture_tracking.MixinSprite",
-    "features.texture_tracking.MixinSpriteIdentifier",
+    "features.texture_tracking.MixinSpriteAtlasTexture",
     "features.world_ticking.MixinClientWorld"
   ]
 }