Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Paintings don't Work #248

Closed
ben9583 opened this issue Aug 12, 2020 · 2 comments · Fixed by #532
Closed

Animated Paintings don't Work #248

ben9583 opened this issue Aug 12, 2020 · 2 comments · Fixed by #532
Labels
S-confirmed Status: Confirmed T-bug Type: Bug

Comments

@ben9583
Copy link

ben9583 commented Aug 12, 2020

Expected Behavior

When a painting with multiple frames from any resource pack is added and placed into the game, the series of images from the resource pack and mcmeta animation file create an animated painting.

Actual Behavior

When you place an animated painting in game, it shows the first frame, but does not progress through and is static.

Reproduction Steps

  1. Create a vertical strip of images and save as the name of a Minecraft painting (ex: pigscene.png)
  2. Create an mcmeta file with any sort of animation configuration, as shown from the Minecraft wiki, and name it to the name of the painting followed by .mcmeta (ex: pigscene.png.mcmeta)
  3. Place this into a resource pack's texture/painting folder and load the resource pack in game.
  4. Place paintings in game until you get to the modified painting.

Attachments

Example Image (24 frames):
match

Example mcmeta:
{
"animation": {
"frametime": 2
}
}

Output on Vanilla:
expected

Output on Sodium:
actual

  • OS: MacOS Catalina 10.15.6
  • Java Version: 1.8.0_74
  • CPU: Intel i9-9980HK 8-core 2.4GHz (up to 5.0GHz)
  • GPU: AMD Radeon Pro 5500M 8GB VRAM
@ben9583 ben9583 added the T-bug Type: Bug label Aug 12, 2020
@jellysquid3 jellysquid3 added the S-confirmed Status: Confirmed label Aug 15, 2020
@jellysquid3 jellysquid3 added this to the Release 0.2 milestone Aug 15, 2020
FlashyReese added a commit to FlashyReese/sodium-fabric that referenced this issue Dec 21, 2020
@CalXee
Copy link

CalXee commented Jan 15, 2021

Does disabling "Animate Only Visible Textures" fix this issue?

@ben9583
Copy link
Author

ben9583 commented Jan 16, 2021

@CalXee Yes, the paintings animate as normal with the option disabled.

mrmangohands pushed a commit that referenced this issue Feb 25, 2021
Covers a few additional cases such as animated paintings and effect icons. Fixes #248 and #403.
spoorn pushed a commit to spoorn/sodium-forge that referenced this issue Jun 29, 2021
…ffeineMC#532)

Covers a few additional cases such as animated paintings and effect icons. Fixes CaffeineMC#248 and CaffeineMC#403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-confirmed Status: Confirmed T-bug Type: Bug
Development

Successfully merging a pull request may close this issue.

3 participants