Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resolution slider to video settings - Issue #1380 #1409

Closed
wants to merge 7 commits into from

Conversation

akrossu
Copy link

@akrossu akrossu commented Aug 1, 2022

Issue

Description

  • Adds a simple slider element in Video Settings to adjust the full-screen resolution.

Known Issues

  • Does not dynamically set resolution without having to un-fullscreen and re-fullscreen.
  • Does not display resolution when changing settings but displays the settings index value such as 0 - 100 possible resolutions.

Thank you to this pr by Madis0(#957) I was able to get a foot in the door with the issue.

I am aware this is planned for 0.5.0, however, I was very bored and wanted to make my first forked pull request

@akrossu akrossu changed the title Please add the resolution slider to the settings - Issue #1380 Add missing resolution slider to video settings - Issue #1380 Aug 2, 2022
@akrossu akrossu marked this pull request as ready for review August 9, 2022 18:15
@jellysquid3 jellysquid3 deleted the branch CaffeineMC:1.19.x/dev September 12, 2023 19:36
@douira
Copy link
Contributor

douira commented Sep 24, 2023

If there is still interest in this, the branch this is targeting needs to be changed and then it could be reopened. This was only closed because branches were consolidated which resulted in PRs targeting those branches being closed automatically. However, if this PR is outdated or obsolete for other reasons it can just stay closed as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants