-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing graphics sliders #957
Conversation
Mostly ported from Sodium Extra, original by @FlashyReese
Fullscreen slider has no effect for me. That is, I can move it, but it doesn't change the resolution. (the shift-P vanilla slider is also 'moved', but I have to reclick the slider in the vanilla interface for it to actually register that something changed and have the resolution actually switch). When the fullscreen slider is actuated, it shows the index of the resolution in the resolution table, this is very hard to use (for example, 1920x1080@60 is number 45, 1920x1080@59 is 46, 1920x1080@30 is 47, etc, I have 157 different resolutions possible, this is hard to pick one in particular this way, especially since the left-right arrows cannot be use to move 1 by 1). |
You will need to create a new OptionFlag for resolution changes. I used the |
Thanks for the feedback, I've fixed the applying and the value is now shown on hover as well. |
makes a bit more sense because of vignette toggle
@MeeniMc, idk, but that error might be with whatever font it using. |
Well, I did mention this...
|
This causes a bit of a slowdown (especially now that the biome cache is gone) but it shouldn't be too bad...
Why did I ever disable this?
Just curious, is someone still working on the issues or is further development on this currently abandoned? |
Currently abandoned, feel free to take over. |
I wish I could. I can only offer to help with testing things but I can't code. |
If there is still interest in this, the branch this is targeting needs to be changed and then it could be reopened. This was only closed because branches were consolidated which resulted in PRs targeting those branches being closed automatically. However, if this PR is outdated or obsolete for other reasons it can just stay closed as it is. |
Implements:
Fixes #46, therefore finally giving Sodium settings parity with all vanilla sliders!
Note: Draft PR because
Help is appreciated.