Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Changes #604

Closed
wants to merge 17 commits into from
Closed

Minor Changes #604

wants to merge 17 commits into from

Conversation

DragonEggBedrockBreaking
Copy link

@DragonEggBedrockBreaking DragonEggBedrockBreaking commented Mar 24, 2021

I have made some small changes to some parts of the GitHub repository:

  • Fixed broken link in README
  • Some changes in fabric.mod.json

Unlike what many may expect, I did not set the homepage to modrinth/curseforge, and you can find my reasoning in JellySquid's comment on #379

I set the project homepage to https://jellysquid.me/projects/ so that it would be more related to the mods.

@jellysquid3
Copy link
Member

The changes here to the mod manifest are fine, but we should really just remove the bit about issue reporting from our CONTRIBUTING.md, since the issue templates make it redundant.

@DragonEggBedrockBreaking
Copy link
Author

The changes here to the mod manifest are fine, but we should really just remove the bit about issue reporting from our CONTRIBUTING.md, since the issue templates make it redundant.

I removed it now. Is there anything else that I need to change?

@DragonEggBedrockBreaking
Copy link
Author

Fixed some minor consistency issues with the issue and crash report templates.

@DragonEggBedrockBreaking
Copy link
Author

I changed modCompile to modImplementation to keep forwards compatibility with JDK 16 (which requires at least Gradle 7.0-rc1). I know that this mod currently downloads JDK 8 to build this, but since 5545895 bumps loom to 0.6, it seems that this mod's aim is to remain forwards compatible and/or up to date and/or tries to remove deprecated features. This is likely the last change I will do.

@DragonEggBedrockBreaking
Copy link
Author

Loom 0.7-SNAPSHOT will soon be recommended, and Gradle 7.0 is now the latest stable release, but there have been a lot of deprecated features between Gradle 6 and 7, so I will not be including that change in this PR. This also applies to my PRs on Lithium, Phosphor and Hydrogen.

@DragonEggBedrockBreaking
Copy link
Author

DragonEggBedrockBreaking commented Apr 10, 2021

merged/resolved conflicts

@DragonEggBedrockBreaking
Copy link
Author

DragonEggBedrockBreaking commented Apr 11, 2021

Reverted modcompile change due to being implemented by #630 in a way that actually matters.

@DragonEggBedrockBreaking
Copy link
Author

DragonEggBedrockBreaking commented Jun 19, 2021

closing because there will not be 1.16 releases soon, i will re-do this for the 1.17 branch

@DragonEggBedrockBreaking
Copy link
Author

on second thoughts, this PR is too trivial so I will not re-make it (feel free to manually implement some of the things i changed here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants