-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Gradle 7 #630
Upgrade to Gradle 7 #630
Conversation
@@ -1,6 +1,5 @@ | |||
pluginManagement { | |||
repositories { | |||
jcenter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the million dollar question, are there any dependencies on jcenter we have to worry about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nick already said:
I did not replace this with another repoistory (e.g. mavenCentral()) since there seem to be no dependencies that relied on it.
Doesn't loom need an update to 0.7-SNAPSHOT? |
Loom 0.6-SNAPSHOT is enough to build on JDK 16, and is only necessary for a new specific tasks, for example the iris fork of sodium needs it because of the |
Why is this issue being referenced dozens of times on other repositories? 😕 |
Looks like @RDKRACZ is spamming many other repositories to update Gradle/Loom while referencing this issue in the process. I've gone ahead and blocked/reported them, which should put an end to the noise being added to this PR. We obviously don't encourage this kind of nonsense and I have no idea why they're going about spamming other people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The reason the person was doing that was because they wanted to build mod jars with java 16 (especially ones that have fixes in repo but not release yet) so that they can run Minecraft with Java 16 for performance boosts because they read in a gist that newer Java's have better garbage collectors. However, while they believed there were doing good and helping out a ton of people, they went and overdid it by mistake. But some folks educated the person on how to now clone repos and do the changes locally and can build with Java 16 instead of asking for the modder to do so. The person does understand what they did was wrong now so there should be no more repeats of that spam. I just wanted to provide context as to what happened in case anyone was still confused as to what the heck happened. Nothing intentionally malicious but keeping them block is still a valid choice. |
* Remove deprecated JCenter repository * Replace deprecated modCompile with modImplementation * Update to Gradle 7.0
This reverts commit 2071e8e.
* Remove deprecated JCenter repository * Replace deprecated modCompile with modImplementation * Update to Gradle 7.0
mavenCentral()
) since there seem to be no dependencies that relied on it.modCompile
is deprecated in Gradle 7, so it is replaced withmodImplementation
in c67d506.Personal testing showed that the command
gradlew clean build --warning-mode all --no-daemon
resulted in no real performance difference between 6.8.3 and 7.0 (37s and 38s). In best case scenario, performance should increase for incremental builds.The built JAR runs fine on Minecraft 1.16.5 on my end.
I am open to any suggestions to improve this PR.
Environment: