Skip to content

Commit

Permalink
* Added DMM_SHOW_PAGE_PERMALINK constant
Browse files Browse the repository at this point in the history
* Made "Page Permalink" link conditionally display with default as false.
  • Loading branch information
Cais committed Nov 16, 2013
1 parent 23937f6 commit 40fbd49
Show file tree
Hide file tree
Showing 5 changed files with 72 additions and 31 deletions.
83 changes: 55 additions & 28 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion changelog.txt
Expand Up @@ -4,7 +4,8 @@ Changelog: November 16, 2013
== Version 2.2.3 ==
= Code =
* Added support for Post-Format: Link
* Commented out the "Page Permalink" link due to it being very unpopular
* Added DMM_SHOW_PAGE_PERMALINK constant
* Made "Page Permalink" link conditionally display with default as false.

= CSS =
* Added appropriate styling for post-format: link related items
Expand Down
6 changes: 4 additions & 2 deletions desk-mess-mirrored.php
Expand Up @@ -28,7 +28,7 @@
*
* @version 2.2.3
* @date November 16, 2013
* Commented out the "Page Permalink" as an unpopular feature
* Made "Page Permalink" link conditionally display with default as false.
*/

/** Set count variable for author 'mullet' loop */
Expand Down Expand Up @@ -84,7 +84,9 @@
<?php } /** End if - is single */

/** Show a shortlink on the page - requires Jetpack be active */
// dmm_page_link( $text = __( 'Page Permalink', 'desk-mess-mirrored' ) ); ?>
if ( DMM_SHOW_PAGE_PERMALINK ) {
dmm_page_link( $text = __( 'Page Permalink', 'desk-mess-mirrored' ) );
} /** End if - Show Page Permalink */ ?>

<p class="single-meta"><?php the_tags(); ?></p>

Expand Down
7 changes: 7 additions & 0 deletions functions.php
Expand Up @@ -22,11 +22,18 @@
* @version 2.2.1
* @date April 21, 2013
* Expanded use of DMM_HOME_DOMAIN constant
*
* @version 2.2.3
* @date November 16, 2013
* Added DMM_SHOW_PAGE_PERMALINK constant
*/

/** Define Desk Mess Mirrored "Home" domain */
define( 'DMM_HOME_DOMAIN', 'BuyNowShop.com' );

/** Define Show Page Permalink Constant - default: false */
define( 'DMM_SHOW_PAGE_PERMALINK', false );

/**
* Enqueue Comment Reply Script
*
Expand Down
4 changes: 4 additions & 0 deletions readme.txt
Expand Up @@ -20,6 +20,10 @@ This may not be construed as overriding any item with a previously applied licen
4. screenshot-4.png - Description: Showcasing the drop-down menu with multiple levels

== Basic FAQ ==
= Q: Where did the >>Page Permalink<< at the bottom of my pages go? =
Although the idea behind adding a link to the bottom of pages was supposed to be useful, it was not popular and as such it has been conditionally set to not be displayed.
There are two ways to display this feature now, in your Child-Theme define `DMM_SHOW_PAGE_PERMALINK` as `true`; or, modify the `functions.php` file to change the default from `false` to `true`

= Q: Why is there a >>Page Permalink<< at the bottom of my pages? Can I hide it? =
The idea is to provide an easy to copy permalink for the article so readers can more easily share the page with others.
You can hide this text by adding `div.page-shortlink{ display:none; }` to your stylesheet.
Expand Down

0 comments on commit 40fbd49

Please sign in to comment.