Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite on error #729

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

rochamarcelo
Copy link
Collaborator

@rochamarcelo rochamarcelo commented Nov 9, 2018

Dont overwrite $user on errors it should not assign a false value

@codecov-io
Copy link

Codecov Report

Merging #729 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #729   +/-   ##
==========================================
  Coverage      81.49%   81.49%           
  Complexity       567      567           
==========================================
  Files             56       56           
  Lines           1735     1735           
==========================================
  Hits            1414     1414           
  Misses           321      321
Impacted Files Coverage Δ Complexity Δ
src/Controller/Traits/PasswordManagementTrait.php 76.25% <100%> (ø) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e2687...7ff3b71. Read the comment docs.

@steinkel steinkel merged commit 15329ef into CakeDC:develop Nov 9, 2018
@rochamarcelo rochamarcelo deleted the feature/avoid-user-overwrite branch November 9, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants