Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 201711 #396

Merged
merged 20 commits into from
Dec 10, 2017
Merged

Cleanup 201711 #396

merged 20 commits into from
Dec 10, 2017

Conversation

mn200
Copy link
Contributor

@mn200 mn200 commented Dec 2, 2017

This successfully builds

  • compiler/backend/proofs
  • basis
  • characteristic

at least.

mn200 and others added 18 commits November 14, 2017 16:24
Guessing that RK's issues arise when lem is run but fails, causing the
script file not to get touched, but allowing addancs to run a second
time.

Progress with #386
Constant of that name and definition already exists in intrealTheory;
the theorems showing the homomorphic connection are new to HOL.
This means that we can accurately record a dependency for the script
files on the corresponding lem files and the addancs tool, but the
latter will not cause a rebuild even though it will have just been
rebuilt. This is the sane as what is being done inside Holmake with
"heap" files.

Requires HOL-Theorem-Prover/HOL@514a40b4a5 or later.
That theorem is now in listTheory under the name LENGTH_MAP2, and is
also an automatic rewrite so didn't need to be quoted at all.
This theorem, along with its friend LIST_REL_SPLIT1, is now an iff
rather than implication so drule fails when applied to it.
@xrchz
Copy link
Member

xrchz commented Dec 2, 2017

This looks to be in a loop in tutorial/solutions

@mn200
Copy link
Contributor Author

mn200 commented Dec 4, 2017

I'll look into it.

@mn200
Copy link
Contributor Author

mn200 commented Dec 6, 2017

I think/hope my fixes in HOL-Theorem-Prover/HOL@1e9e2856a1c may fix the lack of progress in bvl_to_bvi compilation we were seeing.

@xrchz
Copy link
Member

xrchz commented Dec 6, 2017

Can test it again if you can fix the merge conflicts.

@mn200
Copy link
Contributor Author

mn200 commented Dec 7, 2017

Merges OK (as visible above), and builds up to tutorial/solutions, which seems to exercise a fair bit.

@mn200
Copy link
Contributor Author

mn200 commented Dec 9, 2017

examples now also builds

@xrchz xrchz merged commit b580767 into master Dec 10, 2017
@xrchz xrchz deleted the cleanup-201711 branch December 10, 2017 22:32
raksooo pushed a commit to raksooo/cakeml that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants