-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup 201711 #396
Merged
Merged
Cleanup 201711 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More work on this front still to come.
Guessing that RK's issues arise when lem is run but fails, causing the script file not to get touched, but allowing addancs to run a second time. Progress with #386
Constant of that name and definition already exists in intrealTheory; the theorems showing the homomorphic connection are new to HOL.
This means that we can accurately record a dependency for the script files on the corresponding lem files and the addancs tool, but the latter will not cause a rebuild even though it will have just been rebuilt. This is the sane as what is being done inside Holmake with "heap" files. Requires HOL-Theorem-Prover/HOL@514a40b4a5 or later.
That theorem is now in listTheory under the name LENGTH_MAP2, and is also an automatic rewrite so didn't need to be quoted at all.
This theorem, along with its friend LIST_REL_SPLIT1, is now an iff rather than implication so drule fails when applied to it.
This looks to be in a loop in |
I'll look into it. |
I think/hope my fixes in HOL-Theorem-Prover/HOL@1e9e2856a1c may fix the lack of progress in |
Can test it again if you can fix the merge conflicts. |
Merges OK (as visible above), and builds up to |
Proof is now rather shorter.
|
raksooo
pushed a commit
to raksooo/cakeml
that referenced
this pull request
Jan 31, 2018
Cleanup 201711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This successfully builds
compiler/backend/proofs
basis
characteristic
at least.