Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Fix for #93 #95

Closed
wants to merge 2 commits into from
Closed

Temporary Fix for #93 #95

wants to merge 2 commits into from

Conversation

alvinwan
Copy link
Contributor

In case it's needed

@alvinwan alvinwan mentioned this pull request Jun 25, 2015
@Sumukh
Copy link
Member

Sumukh commented Jun 25, 2015

@albert12132 should weigh in on this.

This probably isn't the best solution because we'll end up storing an invalid access token. One approach we can try instead is a simply putting this in a try/except block and print an error message.

@alvinwan
Copy link
Contributor Author

That's fair - just let me know if you want the fix.

@soumyabasu
Copy link
Contributor

Thinking about this issue a little more- I think we should have a try/except block. If they don't get an authentication token, we should tell students to try again in a couple of minutes and if it still fails, to get in touch with staff/ok-support.

@papajohn
Copy link
Contributor

@soumyabasu I'm not too familiar with this issue. I'll let you and @alvinwan decide what's best (or @albert12132 or @Sumukh , though my guess is that they are going to be very busy this week).

@Sumukh
Copy link
Member

Sumukh commented Sep 9, 2015

Closing for now - though having better error messages for students is still an open problem.

@Sumukh Sumukh closed this Sep 9, 2015
@Sumukh Sumukh deleted the bug/alvin/tempCONNfix branch June 30, 2016 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants