Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced file field required option doesn't block users to click and go to next page #2021

Closed
New0 opened this issue Oct 17, 2017 · 4 comments
Closed

Advanced file field required option doesn't block users to click and go to next page #2021

New0 opened this issue Oct 17, 2017 · 4 comments
Assignees
@Shelob9 @New0
Labels
Bug
Milestone
1.5.8

Comments

@New0
Copy link
Collaborator

New0 commented Oct 17, 2017

What Version Of Caldera Forms, WordPress and PHP Are You Using?

WordPress Version: 4.8.2
PHP Version: 7.0.20-2~ubuntu14.04.1+deb.sury.org+1
MySQL Version: 5.5.5
Caldera Forms Version: 1.5.6.1

What Is The Unexpected Behaviour?

On a multi page form, the advanced fiel field required option doesn't block users to click and go to next page, when I get to the submit button the form is not sent but no errors are thrown ( no console error or debug.log error)
@Shelob9 Shelob9 added the Bug label Oct 18, 2017
@Shelob9 Shelob9 added this to the 1.5.7 milestone Oct 18, 2017
@Shelob9
Copy link
Collaborator

Shelob9 commented Oct 18, 2017

@New0 Let's look at this one together. Get your brain ticking on how per page (tab really) validation should work vs how it works :)

@Shelob9
Copy link
Collaborator

Shelob9 commented Oct 23, 2017

Probably related: #1765

Probably relevant: https://stackoverflow.com/questions/24246098/parsley-custom-validator-is-not-working-for-javascript-installation

Shelob9 pushed a commit that referenced this issue Oct 24, 2017
Use the right value to indicate that a file field is valid #2021
79e9e02
@Shelob9
Copy link
Collaborator

Shelob9 commented Oct 24, 2017

Ok, this was way less bad then it I thaught it was. We were echoing the wrong variable to output required.

79e9e02 fixes this, but for some reason, and probably the same reason this only broke on multi-page, it validates on multi-page forms, but prints double errors.

@Shelob9 Shelob9 modified the milestones: 1.5.7, 1.5.8 Nov 8, 2017
Shelob9 pushed a commit that referenced this issue Nov 26, 2017
validate the correct element for adv fields
e1db162 
#2021
This was referenced Nov 26, 2017
Merged
Closed
Shelob9 added a commit that referenced this issue Dec 13, 2017
@Shelob9
Merge pull request #2098 from CalderaWP/feature/2021-b
f8e8299 
Validate advanced file fields on multi-page forms properly Fixes #2021
@Shelob9
Copy link
Collaborator

Shelob9 commented Dec 13, 2017

close via #2098

@Shelob9 Shelob9 closed this as completed Dec 13, 2017
@Shelob9 Shelob9 mentioned this issue Jun 6, 2018
Closed
@Shelob9 Shelob9 mentioned this issue Jan 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shelob9 Shelob9

@New0 New0

Labels
Bug
Projects
None yet
Milestone
1.5.8
Development

No branches or pull requests
2 participants
@Shelob9 @New0