Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move upload dataset card and components to tdp_uploaded_data #286

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Apr 16, 2021

Closes https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1177

Related PR https://github.com/datavisyn/tdp_uploaded_data/pull/90

Summary

  • Move ListItemDropdown to public components to allow reusage in tdp_uploaded_data
  • Move upload dataset card and components to tdp_uploaded_data

As it is still used by the SessionDropzone component
@thinkh thinkh added release: minor PR merge results in a new minor version type: feature New feature or request labels Apr 16, 2021
# Conflicts:
#	dist/internal/components/dataset/NamedSetList.js
#	dist/internal/components/dataset/NamedSetList.js.map
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@oltionchampari oltionchampari merged commit 8c6f207 into welcome-page Apr 20, 2021
@oltionchampari oltionchampari deleted the thinkh/1177_uploaded_data branch April 20, 2021 11:54
@dvvanessastoiber dvvanessastoiber mentioned this pull request Oct 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants