Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extension point interfaces #289

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Apr 20, 2021

Summary

  • Removed IStartMenuDatasetSectionTab -> moved to tdp_publicdb

In IStartMenuDatasetSectionDesc:

  • Renamed headerIcon to icon
  • Renamed viewId to startViewId
  • Added idType

* Removed `IStartMenuDatasetSectionTab`

In `IStartMenuDatasetSectionDesc`:
* Renamed `headerIcon` to `icon`
* Renamed `viewId` to `startViewId`
* Added `idType`
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@oltionchampari oltionchampari merged commit 1f494ed into welcome-page Apr 20, 2021
@oltionchampari oltionchampari deleted the thinkh/refactor-ep-interfaces branch April 20, 2021 12:39
@dvvanessastoiber dvvanessastoiber mentioned this pull request Oct 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants