Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do no destroy tabs when switching between start menu tabs #326

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Do no destroy tabs when switching between start menu tabs #326

merged 4 commits into from
Aug 13, 2021

Conversation

oltionchampari
Copy link
Contributor

Coming from datavisyn/ordino_bayer_indications#252

Summary

  • Added a class 'd-none' when the tab is closed instead of destroying the tab entirely
  • Fixed a minor bug, the image is not yet available in the tours on first render

@oltionchampari oltionchampari added type: feature New feature or request type: refactor Refactor the current implementation labels Aug 11, 2021
@oltionchampari oltionchampari mentioned this pull request Aug 11, 2021
Merged
@thinkh thinkh changed the base branch from bootstrap-v5 to develop August 13, 2021 21:16
thinkh
thinkh approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests as expected. I could not find any side effects so far.

@thinkh thinkh merged commit 00fa034 into develop Aug 13, 2021
@thinkh thinkh deleted the och/start-menu-tab-switching branch August 13, 2021 21:29
@oltionchampari oltionchampari mentioned this pull request Sep 28, 2021
Merged
@dvvanessastoiber dvvanessastoiber mentioned this pull request Oct 7, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
type: feature New feature or request type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oltionchampari @thinkh