Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt header as the figma prototype #90

Merged
merged 2 commits into from
May 3, 2021
Merged

Adapt header as the figma prototype #90

merged 2 commits into from
May 3, 2021

Conversation

oltionchampari
Copy link
Contributor

Closes Caleydo/tdp_bi_bioinfodb#1212

@oltionchampari oltionchampari added type: refactor Refactor the current implementation release: minor PR merge results in a new minor version labels Apr 27, 2021
@oltionchampari oltionchampari mentioned this pull request Apr 27, 2021
Merged
thinkh
thinkh requested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header still looks the same as before:

grafik

Does this PR require Caleydo/ordino#294?

src/initialize.app.ts Outdated Show resolved Hide resolved
src/initialize.app.ts Outdated Show resolved Hide resolved
@oltionchampari
Copy link
Contributor Author

The header still looks the same as before:

grafik

Does this PR require Caleydo/ordino#294?

It does require Caleydo/ordino#294, failed to write it.

thinkh
thinkh approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks fine in combination with Caleydo/ordino#294

@thinkh thinkh merged commit c1748c7 into welcome-page May 3, 2021
@thinkh thinkh deleted the ochampari/hide-right-menu-options branch May 3, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oltionchampari @thinkh