Show current analysis session menu items and sort the menu #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oltionchampari
added
type: refactor
thinkh
approved these changes
May 3, 2021
|
|
||
| currentSessionNav.onclick = (event) => { | ||
| event.preventDefault(); | ||
| setActiveTab(tabs[1]); // TODO: find better way to identify the tabs |
There was a problem hiding this comment.
I also don't have a better idea right now. We have to refactor/extract the tabs anyway to somewhere else in the future. Maybe then we have a better idea.
| @@ -166,7 +183,7 @@ export function CommonSessionCard({cardName, faIcon, cardInfo, children}: ICommo | |||
|
|
|||
| return <> | |||
| <h4 className="text-left d-flex align-items-center mb-3"><i className={`mr-2 ordino-icon-2 fas ${faIcon}`} ></i>{cardName}</h4> | |||
| <Card ref={parent} className="shadow-sm"> | |||
| <Card ref={parent} className={`card-shadow ${highlight ? 'highlight-card' : ''}`} onAnimationStart={onHighlightAnimationStart} onAnimationEnd={onHighlightAnimationEnd}> | |||
There was a problem hiding this comment.
I've added the onAnimationStart and onAnimationEnd event listeners from React. They are fired when the CSS animation starts/ends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Caleydo/tdp_bi_bioinfodb#1216, Caleydo/tdp_bi_bioinfodb#1212
Related PR Caleydo/ordino_public#90
Summary
TODO
Screenshot