Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new onboarding tours #200

Merged
merged 49 commits into from
Apr 18, 2023
Merged

feat: add new onboarding tours #200

merged 49 commits into from
Apr 18, 2023

Conversation

dvmichaelpeterseil
Copy link
Contributor

@dvmichaelpeterseil dvmichaelpeterseil commented Sep 5, 2022 •
edited by oltionchampari
Loading

Completes 'Add case studies from Ordino and Taggle papers as onboarding tours' #1365

Developer Checklist (Definition of Done)

Add following Onboarding Tours:

  1. Assess Breast Cancer Cell Lines ✔️
  2. Prediction of TP53 Mutation Status ✔️
  3. Drug Target Discovery ✔️

See related PR in Caleydo/ordino

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • The 3 additional tours have been functionally completed.
  • The second tour was split into two separate tours (as requested), resulting in a total of 4 new tours.
  • Aesthetic improvements (updated photos, improved UI spacing)

Screenshots

Additional notes for the reviewer(s)

Some changes to the text throughout the tour may need to be made.

Thanks for creating this pull request 🤗

@dvflorianengertsberger
add data-testid
384e09f
@dvvanessastoiber
add id for dataset searchbox
e464ad3
@dvflorianengertsberger
add data-testid to react select components
5879b89
@dvvanessastoiber
Merge remote-tracking branch 'origin/develop' into cypress-testing
5a31382
@dvvanessastoiber
fix lint
452b83e
@dvflorianengertsberger
fix react select error
d81f7a9
@dvvanessastoiber
Merge remote-tracking branch 'origin/develop' into cypress-testing
5a28b07
@dvvanessastoiber
update dist
761c42f
@dvvanessastoiber
Merge remote-tracking branch 'origin/develop' into cypress-testing
d22cb38
@dvvanessastoiber
update dist
caec0d4
@dvvanessastoiber
rename for constistency
e71f24e
@dvvanessastoiber
Merge remote-tracking branch 'origin/develop' into cypress-testing
617bc8c
@dvvanessastoiber
update dist
3946d4e
@dvvanessastoiber
Merge remote-tracking branch 'origin/develop' into cypress-testing
b944ee0
@thinkh
Fix typings
ee11bbc 
Requires datavisyn/tdp_core#749
@dvvanessastoiber
add index.js
fbc855a
@dvvanessastoiber
fix setup
2867237
@dvvanessastoiber
update imports and function calls
e0d7459
@dvvanessastoiber
update video
2fd228f
@dvmichaelpeterseil
Refactored cy related files for Cypress v10
1e07eb1
@dvmichaelpeterseil
Test Duplicant Tour
992a58d
@dvmichaelpeterseil
Halfway with AssessBCCellLines tour
de915c9
@dvmichaelpeterseil
Almost done AssessBCCellLines tour
1443bda
@dvmichaelpeterseil
Merge remote-tracking branch 'origin/develop' into sorry_cypress_testing
3f9ca9f
@dvmichaelpeterseil
Merge remote-tracking branch 'origin/sorry_cypress_testing' into dvMi…
ff6fb0e 
…ke/1365_Additional-Tours
@dvmichaelpeterseil
Update Dist
f23554c
@dvmichaelpeterseil
Fixed Hidden Modal Bug
5eab43a
@dvmichaelpeterseil
AssessBCCellLines Tour Complete (Unpolished)
f52de57
@dvmichaelpeterseil
AssessBCCellLine Tour Complete (Polished)
38fbf9e
@dvmichaelpeterseil
Prep PredictionTP53Tour and slight refactoring
cbfdd78
@dvmichaelpeterseil dvmichaelpeterseil marked this pull request as ready for review April 3, 2023 12:26
@thinkh thinkh changed the title (1365) First Additional Tour Added - AssessBCCellLineTour feat: add new onboarding tours Apr 5, 2023
@oltionchampari
Copy link
Contributor

@thinkh

  1. I have made some minor changes to the selectors, mostly regarding the adding data columns.
  2. For some needed core changes, please see feat: make width of step modal dependent on the step count datavisyn/tdp_core#842
  3. I have tested all tours again and fixed any regressions I found.
  4. Functionally (waiting and selecting), everything works great and all the steps run through
  5. I have not reviewed the content for any typos or logic errors

@oltionchampari oltionchampari added the release: minor PR merge results in a new minor version label Apr 7, 2023
@thinkh thinkh self-assigned this Apr 18, 2023
thinkh
thinkh approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed with Thomas to merge this PR and review the tours in the develop instance. Feedback and possible bug fixes will be addressed in a follow-up PR.

@thinkh thinkh merged commit 75f681a into develop Apr 18, 2023
@thinkh thinkh deleted the dvMike/1365_Additional-Tours branch April 18, 2023 06:49
@thinkh thinkh mentioned this pull request Jul 28, 2023
Merged
dvvanessastoiber added a commit that referenced this pull request Jul 28, 2023
@dvvanessastoiber
Release 14.0.0 (#225)
b9c2103 
## What's Changed

### Features

* Add new onboarding tours by @dvmichaelpeterseil in
#200

### Bugfixes

* Add `SQLMappingProvider` to the registry by @oltionchampari in
#218
* Fix data mapping for boxplot column by @thinkh in
#223
* Improvements to new tours by @oltionchampari in
#222

### Chore
* Migration to visyn_core by @oltionchampari in
#217
* React 18 Migration by @dvmoritzschoefl in
#219
* Update dist folder by @dvvanessastoiber in
#220
* Add numpy to requirements.txt by @thinkh in
#221

### CI
* Add permission to build.yml by @thinkh in
#224

## New Contributors
* @dvmichaelpeterseil made their first contribution in
#200
* @dvmoritzschoefl made their first contribution in
#219

**Full Changelog**:
v13.1.1...v14.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dvmichaelpeterseil @oltionchampari @thinkh @dvflorianengertsberger @dvvanessastoiber