Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add SQLMappingProvider to the registry #218

Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix: add SQLMappingProvider to the registry #218

merged 3 commits into from
Apr 5, 2023

Conversation

oltionchampari
Copy link
Contributor

Closes
Fixes the idtypes not working

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Add SQLMappingProvider to the registry
  • This is the only thing missing to make the id mapping work

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@oltionchampari oltionchampari added type: bug Something isn't working release: minor PR merge results in a new minor version labels Mar 23, 2023
@oltionchampari oltionchampari self-assigned this Mar 23, 2023
@thinkh thinkh changed the title Add SQLMappingProvider to the registry Fix: add SQLMappingProvider to the registry Mar 24, 2023
@thinkh thinkh changed the title Fix: add SQLMappingProvider to the registry Fix: add SQLMappingProvider to the registry Mar 24, 2023
thinkh
thinkh approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It works in my tests.

image

image

@thinkh thinkh changed the title Fix: add SQLMappingProvider to the registry fix: add SQLMappingProvider to the registry Apr 5, 2023
@thinkh thinkh merged commit 2ca59fd into develop Apr 5, 2023
@thinkh thinkh deleted the och/register-sql-mapping-provider branch April 5, 2023 12:45
@thinkh thinkh mentioned this pull request Jul 28, 2023
Merged
dvvanessastoiber added a commit that referenced this pull request Jul 28, 2023
@dvvanessastoiber
Release 14.0.0 (#225)
b9c2103 
## What's Changed

### Features

* Add new onboarding tours by @dvmichaelpeterseil in
#200

### Bugfixes

* Add `SQLMappingProvider` to the registry by @oltionchampari in
#218
* Fix data mapping for boxplot column by @thinkh in
#223
* Improvements to new tours by @oltionchampari in
#222

### Chore
* Migration to visyn_core by @oltionchampari in
#217
* React 18 Migration by @dvmoritzschoefl in
#219
* Update dist folder by @dvvanessastoiber in
#220
* Add numpy to requirements.txt by @thinkh in
#221

### CI
* Add permission to build.yml by @thinkh in
#224

## New Contributors
* @dvmichaelpeterseil made their first contribution in
#200
* @dvmoritzschoefl made their first contribution in
#219

**Full Changelog**:
v13.1.1...v14.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@oltionchampari oltionchampari

Labels
release: minor PR merge results in a new minor version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oltionchampari @thinkh