Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build when using mixed objc/swift projects #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build when using mixed objc/swift projects #58

wants to merge 2 commits into from

Commits on Oct 15, 2020

  1. Update PopMenuViewController.swift 

    Remove @objc modifiers. They cause mixed objc/swift projects to fail to compile because any class that uses the delegate won't be able to find the delegate definition in the bridge file. 

This is because the protocol passes PopMenuViewController but that class is not @objc compatible.  

Remove the @objc, remove the optional because it requires objc. It's irrelevant anyway because there is only one function, therefore anyone passing in the delegate should implement that function
    @StainlessStlRat
    StainlessStlRat committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    eec2be6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from StainlessStlRat/StainlessStlRat-patch-1 

    Update PopMenuViewController.swift
    @StainlessStlRat
    StainlessStlRat committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2ef9262 View commit details
    Browse the repository at this point in the history