Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build when using mixed objc/swift projects #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build when using mixed objc/swift projects #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec2be6
Update PopMenuViewController.swift
StainlessStlRat Oct 15, 2020
2ef9262
Merge pull request #1 from StainlessStlRat/StainlessStlRat-patch-1
StainlessStlRat Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions PopMenu/View Controller & Views/PopMenuViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import UIKit

/// Delegate for handling PopMenu selection.
@objc public protocol PopMenuViewControllerDelegate: class {
public protocol PopMenuViewControllerDelegate: class {
/// Called when an action is selected.
@objc optional func popMenuDidSelectItem(_ popMenuViewController: PopMenuViewController, at index: Int)
optional func popMenuDidSelectItem(_ popMenuViewController: PopMenuViewController, at index: Int)
}

final public class PopMenuViewController: UIViewController {
Expand Down Expand Up @@ -623,7 +623,7 @@ extension PopMenuViewController {
}

// Notify delegate
delegate?.popMenuDidSelectItem?(self, at: index)
delegate?.popMenuDidSelectItem(self, at: index)

// Should dismiss or not
if shouldDismissOnSelection {
Expand Down