Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta.11 intercom no longer opens/loads #32

Closed
matt-filion opened this issue Jan 24, 2018 · 7 comments
Closed

Beta.11 intercom no longer opens/loads #32

matt-filion opened this issue Jan 24, 2018 · 7 comments

Comments

@matt-filion
Copy link

It does not appear to be calling the l() function within the util/load-intercom.ts file anymore.

@wbhob
Copy link
Contributor

wbhob commented Jan 25, 2018

Do you have any other information? Errors in the console, or something that would lead you to believe that that is the case? The code has not changed for that function, and it is ported directly from Intercom.

@matt-filion
Copy link
Author

matt-filion commented Jan 25, 2018 via email

@wbhob
Copy link
Contributor

wbhob commented Jan 25, 2018

window.onLoad should be invoking it in compatible browsers, if not, it adds an eventlistener for load.

@MarkusPint
Copy link

MarkusPint commented Mar 22, 2018

I can confirm this. It happens on beta.12 too and switching back to beta.10 fixes it. There are no errors in console.

@worldspawn
Copy link

I'm using beta11 on one site without issue and on another using beta11 the load event has fired at the time the intercom runs loadIntercom. Nfi why, it's all initialised in the same way. Only thought I had it something to do with how the modules were bundled (for lazy loading).

Could we perhaps do something like:

else {
  if (w.document.readyState === 'complete')
     l();
  else {
     w.addEventListener('load', l, false);
  }
}

Though when i try that i get this in my log output
image

@sijmenvos
Copy link

I can also confirm this, when using 1.0.0-beta.10 Intercom loads, on 1.0.0-beta.13 it doesn't either.

@scott-wyatt
Copy link
Member

Marking this as a deprecated issue. Feel free to reopen another issue if this persists in a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants