-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta.11 intercom no longer opens/loads #32
Comments
Do you have any other information? Errors in the console, or something that would lead you to believe that that is the case? The code has not changed for that function, and it is ported directly from Intercom. |
When I changed back to .10 it worked. I'll dig a bit deeper to see what I
can find. In the latest version I could not place what is calling the l()
function. Do you know what is "supposed" to be invoking it?
…On Jan 24, 2018 5:15 PM, "Wilson Hobbs" ***@***.***> wrote:
Do you have any other information? Errors in the console, or something
that would lead you to believe that that is the case? The code has not
changed for that function, and it is ported directly from Intercom.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUplLt3EMvso6qM9cCuiGfnHymHderpks5tN9W0gaJpZM4RsAI6>
.
|
window.onLoad should be invoking it in compatible browsers, if not, it adds an eventlistener for load. |
I can confirm this. It happens on beta.12 too and switching back to beta.10 fixes it. There are no errors in console. |
I'm using beta11 on one site without issue and on another using beta11 the load event has fired at the time the intercom runs Could we perhaps do something like: else {
if (w.document.readyState === 'complete')
l();
else {
w.addEventListener('load', l, false);
}
} |
I can also confirm this, when using 1.0.0-beta.10 Intercom loads, on 1.0.0-beta.13 it doesn't either. |
Marking this as a deprecated issue. Feel free to reopen another issue if this persists in a later version. |
It does not appear to be calling the l() function within the util/load-intercom.ts file anymore.
The text was updated successfully, but these errors were encountered: