Route performance problems using updateOnRouterChange

[andy-hook]

Versions

• Angular: 8.2.8
• Angular CLI: 8.3.6
• ng-intercom: 8.0.0
• Node.JS: 10.11.0
• NPM: 6.4.1

Description

I'm experiencing significant performance problems when changing routes with updateOnRouterChange enabled. In my profiler some of my tasks takes up to 5 or 6 times as long.

Here's an example from clicking between two routes in my app:

updateOnRouterChange: false

updateOnRouterChange: true

Has anyone come up against these issues before?

[andy-hook]

I did some digging and the intercom update function is being called many times due to a subscription matching all router events. Changing this to match for NavigationEnd should fix the issue.

[andy-hook]

Hi @scott-wyatt @wbhob – Are you able to publish with this change?

[andy-hook]

@scott-wyatt, @wbhob – I hate to be that guy but what's the eta on getting 8.0.1 published to npm?

[scott-wyatt]

Opps! Sorry about that, I thought it published. I’ll publish it to npm this morning Sent from out and about

…

On Jan 15, 2020, at 2:50 AM, Andy Hook ***@***.***> wrote:  Hi @scott-wyatt @wbhob – Are you able to publish with this change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[andy-hook]

Thanks for getting this out! 🎉