Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with routing performance when using updateOnRouterChange #98

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

andy-hook
Copy link

@andy-hook andy-hook commented Jan 10, 2020

Fix for #97

Summary of changes:

Intended/example use case:

When using updateOnRouterChange the update would fire multiple times per route change causing performance problems. With this change the update will fire only once after a successful navigation.

Checklist:

  • npm run build runs without error
  • ng serve spawns app, Intercom messenger is visible and interactive, and there are no errors in the console

Closes issue: #

@scott-wyatt
Copy link
Member

Thanks @andy-hook! I’ll take a look to see what’s happening with the test.

@andy-hook
Copy link
Author

Great, thank you @scott-wyatt

@wbhob wbhob self-requested a review January 10, 2020 19:27
Co-Authored-By: Wilson Hobbs <wilsonhobbs1@gmail.com>
@andy-hook
Copy link
Author

Hi @wbhob @scott-wyatt, thanks for looking at this. Is there anything more I can do to get this out in a patch release?

@scott-wyatt scott-wyatt merged commit f6b1133 into CaliStyle:master Jan 13, 2020
@scott-wyatt
Copy link
Member

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants