Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental Angular 6 support. Upgraded most modules and configurations that seemed relevant, mainly using steps outlined here: https://update.angular.io/. Should work for regular usage but not ready for merge to keep what I think is the development environment intact.
Tests seem to pass and can run the regular client development environment where Intercom does get launched and seem to work.
Building for the server however fails, also meaning that
npm test
ultimately fails due to ending with building and running a server client. Here is the error:Agreed to add webpack-cli automatically the first time another seemingly related issue occurred.
Quite unfamiliar with the used SSR configuration, NGRX, ng-engine and trails config used in the library. And as it at least seems to have reached the goal of implementing Angular 6 for downstream consumers I'm hoping to leave the rest of the work for someone else. Where I hope this will either help someone else with a PR of the very same purpose or allow someone to simply iterate in this PR.
Closes #47