DM-10523: period finder layout up to date with plotly version

[ejoliet]

The pull request take care of a version left over from RC and include it in the plotly recently created in dev.
The period finder layout has changed according to the feedback during the test campaign and the version needed to be merged in the plotly version.

Test: bring the LC tool, and go to period finder. The button of the form are now under the control panel, no period value is set by default and title have been added to the plots.

[tgoldina]

I have pushed a fix for title and selection rectangle not being shown with log scale.

I still see at least one issue: when you select period by clicking on the periodogram, the period in 'Set period' section is populated correctly, but the phase finding chart reflects the previous period value, not the current one. You have to hover over a point for the chart to update to reflecting the current period. (Same behavior with peak table.)

Also, when you first click 'Period Finder', the chart shows with period=NaN day.

[tgoldina]

Before the merge, please fix the delay in update of phase folding chart. I think it's a simple fix. Just switch the order of lines 391 and 397 in LcPeriodPlotly.js

It would be also nice to fix period=NaN days.

Otherwise looks good.

[ejoliet]

Ok, i will try the fix @tgoldina suggest. Thank you.

About the title NaN (days) there are more issue about it and it should be in another ticket. For example, what happen if my data is not in days, etc. See IRSA-354.