DM-11457: Selected table rows should be kept after sorting

[loitly]

https://jira.lsstcorp.org/browse/DM-11457

As described in the ticket, selection info should be kept after sorting and filtering.
In the case of filtering, when a selected row is removed due to a filter, it will be removed from selection info as well. This is to ensure that the selection info is valid for the current view.

For example:

• select all, apply a filter.
• all rows are still selected.
• clear filters
• only the previously selected rows are selected.

Also in this ticket, null values are sorted to top for ascending and to the bottom on descending.

This ticket can be tested on any table.

[ejoliet]

I've built IRSAViewer and when i do a filter / sort with rows selected (not all) it doesn't seems to respect the rows selected. I was expecting that if i select a row and filter or sort, the same row stays selected if the filter is positive or if sorted the row should 'move' and kept the selection, i don't see that in my local.

[tgoldina]

It works as described in both firefly and irsaviewer. I tried sorting and filtering from table, chart, and image plot. The rows selected in the previous iteration stay selected.

[loitly]

@ejoliet, I've just pushed a commit to fix the problem you saw in irsaviewer. It was a bug in table support. However, it was masked by plot.ly chart's code. That's why it was not noticeable in firefly and only in irsaviewer. Please check again.

[cwang2016]

Here are some cases I found,

• catalog search, and do 'select all' on the table, 'select area' to cover partial points on the coverage and select 'filter' from context tool bar, some of the filtered points on the table become un-selected, is this as design?
• the sorting on client table doesn't work correctly in case there is null or undefined data.

[ejoliet]

Last push fixes what i've seen in irsaviewer. Good to go.

[loitly]

catalog search, and do 'select all' on the table, 'select area' to cover partial points on the coverage and select 'filter' from context tool bar, some of the filtered points on the table become un-selected, is this as design?

It's a bug. I've fixed it.